Skip to content

docs(progress-bar) : Textual improvements for Buffer & Query modes #20093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2020
Merged

docs(progress-bar) : Textual improvements for Buffer & Query modes #20093

merged 2 commits into from
Jul 27, 2020

Conversation

walvekarnikhil
Copy link
Contributor

Fixes #19817

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 25, 2020
crisbeto
crisbeto reviewed Jul 26, 2020
View reviewed changes
src/material/progress-bar/progress-bar.md Outdated
@@ -20,17 +20,16 @@ not necessary to indicate how long it will take should use the indeterminate ind
In this mode the `value` property is ignored.

#### Buffer
Operations where the user wants to indicate some activity or loading from the server,
use the buffer indicator.
Use the buffer indicator when want to indicate some activity or loading from the server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"when want" -> "when you want"

crisbeto
crisbeto approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jul 27, 2020
@jelbourn jelbourn added the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label Jul 27, 2020
@jelbourn jelbourn merged commit e6fd325 into angular:master Jul 27, 2020
jelbourn pushed a commit that referenced this pull request Jul 27, 2020
@walvekarnikhil @jelbourn
docs(material/progress-bar) : improve wording for buffer & query modes (
cd2f2e0 
#20093)

Fixes #19817

(cherry picked from commit e6fd325)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs-bug(COMPONENT): Textual improvements of the progress-bar documentation
4 participants
@walvekarnikhil @crisbeto @jelbourn @googlebot